Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-46] refactor: replaced set-output in CI/CD configuration #2807

Merged
merged 2 commits into from
Nov 17, 2023
Merged

[BD-46] refactor: replaced set-output in CI/CD configuration #2807

merged 2 commits into from
Nov 17, 2023

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Nov 13, 2023 •
edited
Loading

Description

  • replaced set-output

Issue: #2718

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 13, 2023 •
edited
Loading

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Nov 13, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited
Loading

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9768cb6
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6557262da16e2d0008abb353
😎 Deploy Preview https://deploy-preview-2807--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft November 13, 2023 11:59
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b29abc0) 92.83% compared to head (9768cb6) 92.83%.
Report is 7 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2807   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         235      235           
  Lines        4240     4240           
  Branches     1029     1029           
=======================================
  Hits         3936     3936           
  Misses        300      300           
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this pull request Nov 16, 2023
Closed
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/removed-set-output branch 7 times, most recently from ed571e3 to 00e3e3b Compare November 16, 2023 21:03
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/removed-set-output branch from 24f0b76 to 0dd48bd Compare November 16, 2023 21:18
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review November 16, 2023 21:18
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] refactor: added use of environment files [BD-46] refactor: replaced set-output Nov 16, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] refactor: replaced set-output [BD-46] refactor: replaced set-output in CI/CD configuration Nov 16, 2023
@viktorrusakov viktorrusakov linked an issue Nov 17, 2023 that may be closed by this pull request
set-output (used in "Extract branch name" CI step) is deprecated #2718
Closed
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft November 17, 2023 08:32
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review November 17, 2023 08:48
@viktorrusakov viktorrusakov merged commit 3c0729b into openedx:master Nov 17, 2023
8 checks passed
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 21.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 22.0.0-alpha.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktorrusakov viktorrusakov viktorrusakov approved these changes

@monteri monteri Awaiting requested review from monteri

Assignees
No one assigned
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
2U Blended Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set-output (used in "Extract branch name" CI step) is deprecated
4 participants
@PKulkoRaccoonGang @openedx-webhooks @openedx-semantic-release-bot @viktorrusakov